cmse: disallow impl Trait in cmse-nonsecure-entry return types
#147243
+72
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #75835
fixes #147242
Refactors some logic to be more robust in the future, and then disallows
impl Traitas a return type for the cmse ABIs.The
is_valid_cmse_output_layoutfunction disallowsunionvalues like before. That is not entirely correct preserves the current behavior. Some additional logic is needed forunionvalues (and any types where parts may be uninitialized) that I'll tackle in a later PR.can be reviewed commit-by-commit.
r? types