Skip to content

Conversation

Jules-Bertholet
Copy link
Contributor

Partial fix for #147303.

@rustbot label A-diagnostics A-suggestion-diagnostics D-invalid-suggestion

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 3, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code. labels Oct 3, 2025
@chenyukang
Copy link
Member

maybe it's better to fix 147303
pattern matching suggestiong: you might have meant to pattern match on the similarly named constant should not report on function arguments positions.

@chenyukang
Copy link
Member

I created a fix for 147303: #147320

@Jules-Bertholet
Copy link
Contributor Author

maybe it's better to fix 147303 pattern matching suggestiong: you might have meant to pattern match on the similarly named constant should not report on function arguments positions.

Yes, that should be done as well, but this suggestion should not be machine-applicable either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-invalid-suggestion Diagnostics: A structured suggestion resulting in incorrect code. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants