Skip to content

Update cargo submodule #147338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2025
Merged

Update cargo submodule #147338

merged 1 commit into from
Oct 4, 2025
+1 −1

Conversation

weihanglo
Copy link
Member

3 commits in 2394ea6cea8b26d717aa67eb1663a2dbf2d26078..801d9b4981dd07e3aecdca1ab86834c13615737e
2025-10-03 14:13:01 +0000 to 2025-10-04 13:30:15 +0000

r? ghost
fixes #147321

@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Oct 4, 2025

📌 Commit b457877 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025
@weihanglo weihanglo mentioned this pull request Oct 4, 2025
Closed
@bors
Copy link
Collaborator

bors commented Oct 4, 2025

⌛ Testing commit b457877 with merge 99ca0ae...

@bors
Copy link
Collaborator

bors commented Oct 4, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 99ca0ae to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 4, 2025
@bors bors merged commit 99ca0ae into rust-lang:master Oct 4, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 99b9a88 (parent) -> 99ca0ae (this PR)

Test differences

Show 9 test diffs

Stage 2

  • package::reserved_windows_name: pass -> ignore (temporarily disabling due to flakiness: https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/reserved_windows_name.20test.20failing/with/543085230) (J0)
  • build_scripts_multiple::duplicate_build_script_stems: [missing] -> pass (J1)
  • build_scripts_multiple::multiple_out_dirs: [missing] -> pass (J1)
  • profile_panic_immediate_abort::cli_gate_works: [missing] -> ignore (-Cpanic=immediate-abort is unstable) (J1)
  • profile_panic_immediate_abort::gated_config_toml: [missing] -> pass (J1)
  • profile_panic_immediate_abort::gated_manifest: [missing] -> pass (J1)
  • profile_panic_immediate_abort::manifest_gate_works: [missing] -> ignore (-Cpanic=immediate-abort is unstable) (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 99ca0ae87ba5571acee116ea83d1f9e88a7bf8d8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 7442.6s -> 9313.3s (25.1%)
  2. dist-ohos-armv7: 3967.1s -> 4631.3s (16.7%)
  3. aarch64-gnu-llvm-20-1: 3626.4s -> 3353.0s (-7.5%)
  4. dist-x86_64-msvc-alt: 9799.8s -> 9163.5s (-6.5%)
  5. dist-aarch64-apple: 6712.2s -> 6278.9s (-6.5%)
  6. x86_64-gnu-aux: 6810.7s -> 6375.6s (-6.4%)
  7. dist-i586-gnu-i586-i686-musl: 5309.1s -> 5591.1s (5.3%)
  8. dist-x86_64-netbsd: 4876.1s -> 5101.8s (4.6%)
  9. dist-s390x-linux: 5013.3s -> 5240.0s (4.5%)
  10. dist-powerpc-linux: 5052.4s -> 5274.1s (4.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (99ca0ae): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.695s -> 471.44s (0.16%)
Artifact size: 388.35 MiB -> 388.29 MiB (-0.01%)

@saethlin saethlin mentioned this pull request Oct 4, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 4, 2025
@matthiaskrgr
Rollup merge of rust-lang#147349 - saethlin:panic-immediate-advice, r…
97a078e 
…=Noratrieb

Improve the advice given by panic_immediate_abort

Now that rust-lang#147338 is merged, users should consider using the Cargo support for immediate-aborting panics.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147349 - saethlin:panic-immediate-advice, r…
91d7ff9 
…=Noratrieb

Improve the advice given by panic_immediate_abort

Now that rust-lang#147338 is merged, users should consider using the Cargo support for immediate-aborting panics.
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 5, 2025
@Zalathar
Rollup merge of rust-lang#147349 - saethlin:panic-immediate-advice, r…
a0a4905 
…=Noratrieb

Improve the advice given by panic_immediate_abort

Now that rust-lang#147338 is merged, users should consider using the Cargo support for immediate-aborting panics.
rust-timer added a commit that referenced this pull request Oct 5, 2025
@rust-timer
Unrolled build for #147349
bf93a0f 
Rollup merge of #147349 - saethlin:panic-immediate-advice, r=Noratrieb

Improve the advice given by panic_immediate_abort

Now that #147338 is merged, users should consider using the Cargo support for immediate-aborting panics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.92.0
Development

Successfully merging this pull request may close these issues.

cargo package::reserved_windows_name test seems to be flaky
4 participants
@weihanglo @rustbot @bors @rust-timer