Skip to content

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Oct 6, 2025

This PR extracts most of the non-trivial code from the define_feedable! macro (which defines the TyCtxtFeed::$query methods), and moves it to a helper function query_feed_inner written in ordinary non-macro code.

Doing so should make that code easier to read and modify, because it now gets proper IDE support and has explicit trait bounds.


There should be no change in compiler behaviour.

I've structured the commits so that the actual extraction part is mostly just whitespace changes, making it easier to review individually with whitespace changes hidden.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar Zalathar changed the title Extract most code from define_feedable! Extract most code from define_feedable! Oct 6, 2025
@Zalathar
Copy link
Contributor Author

Zalathar commented Oct 6, 2025

No perf changes intended, but let's check:

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-bors bot added a commit that referenced this pull request Oct 6, 2025
Extract most code from `define_feedable!`
@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 6, 2025
@rust-bors
Copy link

rust-bors bot commented Oct 6, 2025

☀️ Try build successful (CI)
Build commit: b135ecc (b135ecc5b5ca9773965d5c7368568e9fe2f0f49c, parent: 1a3cdd34629306fa67624eaa60d73687e7fcf855)

@rust-timer
Copy link
Collaborator

Queued b135ecc with parent 1a3cdd3, future comparison URL.
There are currently 3 preceding artifacts in the queue.
It will probably take at least ~3.6 hours until the benchmark run finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants