Improve diagnostics: update note and add help message #147395
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Kivooeo
reviewed
Oct 6, 2025
| .note = if there is a `mod {$name}` elsewhere in the crate already, import it with `use crate::...` instead | ||
| expand_module_in_block = | ||
| cannot declare a non-inline module inside a block unless it has a path attribute |
There was a problem hiding this comment.
As was little discussed here #147314 (comment), in my opinion it worth to use other than "non-inline" word here, this one is not obvious for non native English speakers, so we could use other one that will be more simple
cc @hkBst
| cannot declare a non-inline module inside a block unless it has a path attribute | ||
| .note = maybe `use` the module `{$name}` instead of redeclaring it | ||
| .help = maybe `use` the module `{$name}` instead of redeclaring it | ||
| .note = modules are usually placed outside of blocks, at the top level of the file |
There was a problem hiding this comment.
Also this note as far as I can say shouldn't say just "modules" but " modules"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the content from the note to a help message, as it seemed more appropriate there, and then added new information to the note(
Modules are usually placed outside of blocks, at the top level of the file)!resolve: #147314