rustdoc: instrument call to lib_embargo_visit_item #147452
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
|
@bors2 try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
rust-bors bot
added a commit
that referenced
this pull request
Oct 7, 2025
…, r=<try> rustdoc: instrument call to lib_embargo_visit_item
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
|
Queued 3ddbf8e with parent 4a54b26, future comparison URL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a thought randomly that we could reduce the amount of times lib_embargo_visit_item is called by only calling it when we want to get the effective visibility of an item in a given crate, since DefId contains a CrateNum. However, this could require some fairly complex locking, so I thought I should instrument this pass to get a ceiling of how much performance gain this could give.
If this would make a difference ever, it would be in crates with a large number of dependencies that are never referenced from the docs (no intra-doc links, trait impls, or re-exports)