Skip to content

Fix double warnings on #[no_mangle] #147467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix double warnings on #[no_mangle] #147467

wants to merge 2 commits into from
+31 −24

Conversation

JonathanBrouwer
Copy link
Contributor

Fixes 2 out of 3 cases in #147417
The fix on closures removes the old error and marks closures as an error target.
The fix on consts adds AllowSilent to to ignore a target, and uses the old error because that one has a nice suggestion.

r? @jdonszelmann

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 8, 2025
jdonszelmann
jdonszelmann reviewed Oct 8, 2025
View reviewed changes
@jdonszelmann
Copy link
Contributor

r=me after comments are addressed @bors delegate+

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

✌️ @JonathanBrouwer, you can now approve this pull request!

If @jdonszelmann told you to "r=me" after making some further change, please make that change, then do @bors r=@jdonszelmann

@JonathanBrouwer
Copy link
Contributor Author

@bors r=@jdonszelmann rollup

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

📌 Commit cdc0e5f has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@JonathanBrouwer
Copy link
Contributor Author

JonathanBrouwer commented Oct 8, 2025 •
edited
Loading

@bors r-
I think this may soft conflict with #147445, wanna check

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonszelmann jdonszelmann jdonszelmann left review comments

Assignees

@jdonszelmann jdonszelmann

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JonathanBrouwer @rustbot @jdonszelmann @bors