-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Gate tests with the right edition #147498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pvdrz
wants to merge
2
commits into
rust-lang:master
Choose a base branch
from
ferrocene:pvdrz/edition-range-gating
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,707
−2,086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
The job Click to see the possible cause of the failure (guessed by this bot)
|
I'll nominate this for compiler team discussion re. "we accepted the MCP for the direction in theory, here's the actual shape of the implementation" for a quick vibecheck. If team is onboard, we'll coordinate to bump the priority of this PR w.r.t. merge conflict potential. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I-compiler-nominated
Nominated for discussion during a compiler team meeting.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
S-waiting-on-t-compiler
Status: Awaiting decision from T-compiler
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR guarantees that
./x test --test-args="--edition XXXX" ui
runs correctly with the 2015, 2018 and 2021 editions.I don't expect this PR to hold up over time but it helps to submit further updates to the
//@ edition
directives of tests where we can use the new range syntax to have a more robust testing across different editionsr? @fmease