Skip to content

Factor out helpers for file times #147504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Factor out helpers for file times #147504

wants to merge 2 commits into from

Conversation

joshtriplett
Copy link
Member

These two helpers should help with the implementation of set_times and
set_times_nofollow for #147455 .

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 9, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 9, 2025

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joshtriplett
Copy link
Member Author

Let's try to catch issues on other platforms:

@bors try

rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors
Auto merge of #147504 - joshtriplett:file-times-helpers, r=<try>
378d1bf 
Factor out helpers for file times
@rust-bors

This comment has been minimized.

Sign in to view
@joshtriplett joshtriplett mentioned this pull request Oct 9, 2025
Open
chenyukang
chenyukang reviewed Oct 9, 2025
View reviewed changes
chenyukang
chenyukang reviewed Oct 9, 2025
View reviewed changes
chenyukang added a commit to chenyukang/rust that referenced this pull request Oct 9, 2025
@chenyukang
rebase rust-lang#147504
8ede1f1
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@joshtriplett
Copy link
Member Author

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors
Auto merge of #147504 - joshtriplett:file-times-helpers, r=<try>
7908204 
Factor out helpers for file times
joshtriplett pushed a commit to chenyukang/rust that referenced this pull request Oct 9, 2025
@chenyukang @joshtriplett
rebase rust-lang#147504
46c6f0a
@rust-bors
Copy link

rust-bors bot commented Oct 9, 2025

☀️ Try build successful (CI)
Build commit: 7908204 (79082042d226f2d6b4ffb52870d5af5e4542a79e, parent: 61efd190243db101d1e47c82c7ec543565c25f62)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenyukang chenyukang chenyukang left review comments

Assignees

@ibraheemdev ibraheemdev

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshtriplett @rustbot @rust-log-analyzer @chenyukang @ibraheemdev