repr_transparent_external_private_fields: normalize types during traversal #147514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
RalfJung
commented
Oct 9, 2025
| // "known" respecting #[non_exhaustive] attributes. | ||
| let field_infos = adt.all_fields().map(|field| { | ||
| let ty = field.ty(tcx, GenericArgs::identity_for_item(tcx, field.did)); | ||
| let typing_env = ty::TypingEnv::non_body_analysis(tcx, field.did); |
There was a problem hiding this comment.
Previously we used the field DefId here, now we're using the DefId of the surrounding ADT -- I hope that doesn't make a difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determining whether a type is a 1-ZST will internally do full normalization, so we better do the same when scanning for non-exhaustive types.
r? @lcnr