Skip to content

Conversation

azhogin
Copy link
Contributor

@azhogin azhogin commented Oct 9, 2025

intrinsic_raw query works like inlined function for non-incremental build and non-local DefId.
In continue of #147232 (couldn't reopen original closed PR).

Optimization may be profitable for queries with low normalized average execution time (to replace cache lookup into inlined call) and be significant with good cache_hits.

Query cache_hits min_ns max_ns avg_ns_norm
source_span 11361 18 2991 66
hir_owner_parent 5773 52 1773 163
is_doc_hidden 3134 47 1111 285
lookup_deprecation_entry 13905 36 6208 287
object_lifetime_default 5840 63 4688 290
upvars_mentioned 2575 75 7722 322
*intrinsic_raw* 21235 73 3453 367

Draft PR to measure performance changes.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 9, 2025
@azhogin
Copy link
Contributor Author

azhogin commented Oct 9, 2025

r? @petrochenkov

@petrochenkov
Copy link
Contributor

@bors2 try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

rust-bors bot added a commit that referenced this pull request Oct 9, 2025
@rust-bors

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 9, 2025
@rust-bors
Copy link

rust-bors bot commented Oct 9, 2025

☀️ Try build successful (CI)
Build commit: 1450ec5 (1450ec5278c285a3eb1b789f156b8d7b1cf83b48, parent: acf243778e6c54cb7d54bee4be88e510e4be123e)

@rust-timer
Copy link
Collaborator

Queued 1450ec5 with parent acf2437, future comparison URL.
There are currently 3 preceding artifacts in the queue.
It will probably take at least ~3.5 hours until the benchmark run finishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants