Replace locals in debuginfo records during ref_prop #147525
Open
+126
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
cjgillot
reviewed
Oct 9, 2025
| location: Location, | ||
| ) { | ||
| if let StmtDebugInfo::AssignRef(local, _) = stmt_debuginfo | ||
| && let Value::Pointer(target, _) = self.targets[*local] |
There was a problem hiding this comment.
If this mirrors visit_var_debug_info, we need an extra condition on target.projection, don't we?
| - StorageDead(_3); | ||
| - StorageDead(_1); | ||
| + // DBG: _1 = &(*_5); | ||
| + // DBG: _5 = &(*_5); |
There was a problem hiding this comment.
Should we keep this statement, or drop it as a tautology?
|
This doesn't fix the case we saw internally in netlink-proto. Could you also give it a shot against the non-minimized reproducer in #147485? |
Had a few minutes, so I checked: with this PR applied the reproducer in https://github.com/krasimirgg/netlink-proto branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147485.
r? cjgillot