Add cargo_cfg_target_family_multivalued lint
#147545
Open
+673
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
added
A-lints
rustbot
added
the
S-waiting-on-review
madsmtm
commented
Oct 10, 2025
| /// | ||
| /// [CARGO_CFG_TARGET_FAMILY]: https://doc.rust-lang.org/cargo/reference/environment-variables.html#:~:text=CARGO_CFG_TARGET_FAMILY | ||
| /// [cfg-target_family]: https://doc.rust-lang.org/reference/conditional-compilation.html#target_family | ||
| CARGO_CFG_TARGET_FAMILY_MULTIVALUED, |
There was a problem hiding this comment.
What do you think about the name? cargo_cfg_target_family_multivalued is kinda long, but I felt that shortening it risked loosing meaning. _multivalued isn't the best descriptor though, perhaps _direct_comparison would be better?
| struct ReplaceWithSplitAny { | ||
| #[suggestion_part(code = "!")] | ||
| negate: Option<Span>, | ||
| #[suggestion_part(code = ".split(',').any(|x| x == ")] |
There was a problem hiding this comment.
We could suggest .contains("unix") instead, that'd work as well. I felt .split(',').any(|x| x == "unix") was more principled, but I'd be fine with either.
| Warn, | ||
| "comparing `CARGO_CFG_TARGET_FAMILY` env var with a single value", | ||
| @future_incompatible = FutureIncompatibleInfo { | ||
| reason: FutureIncompatibilityReason::FutureReleaseSemanticsChange, |
There was a problem hiding this comment.
Unsure if this is the intended use of a FCW? I would like it to trigger in dependents some day, but there wasn't precedent for using FutureReleaseSemanticsChange anywhere.
3 tasks
petrochenkov
added
S-waiting-on-t-lang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
cargo_cfg_target_family_multivaluedwhich detects simple comparisons like==ormatchon theCARGO_CFG_TARGET_FAMILYenvironment variable. These are wrong, sinceCARGO_CFG_TARGET_FAMILYis multi-valued (currently only onwasm32-unknown-emscriptenandwasm32-wali-linux-musl, so admittedly pretty rare).This should unblock at some point adding
#[cfg(target_family = "darwin")], which in turns unblocks #100343.There exist other multi-valued cfgs such as
CARGO_CFG_TARGET_HAS_ATOMICorCARGO_CFG_TARGET_HAS_ATOMIC, but these were very clearly multi-valued from the beginning, and thus doesn't make sense to lint for.This is my first time adding a lint, so beware that I'm a bit unsure if I did things right. Especially unsure if I should feature-gate the lint to start with, or if we should insta-stabilize it? I'm pretty sure it needs a lang FCP though.
r? compiler
CC @thomcc @workingjubilee