Skip to content

TcpListener::bind/TcpStream::connect (&str, Int), &str and SocketAddr{...} overrides #14755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

TcpListener::bind/TcpStream::connect (&str, Int), &str and SocketAddr{...} overrides #14755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f315a17
Prototyping trait-based SocketAddr conversion
thomaslee Jun 7, 2014
afe6a49
Update doc comments
thomaslee Jun 8, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/compiletest/runtest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ fn run_debuginfo_gdb_test(config: &Config, props: &TestProps, testfile: &Path) {
//waiting 1 second for gdbserver start
timer::sleep(1000);
let result = task::try(proc() {
tcp::TcpStream::connect("127.0.0.1", 5039).unwrap();
tcp::TcpStream::connect(("127.0.0.1", 5039)).unwrap();
});
if result.is_err() {
continue;
Expand Down
4 changes: 2 additions & 2 deletions src/libstd/io/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ Some examples of obvious things you might want to do
# #![allow(unused_must_use)]
use std::io::net::tcp::TcpStream;

let mut socket = TcpStream::connect("127.0.0.1", 8080).unwrap();
let mut socket = TcpStream::connect(("127.0.0.1", 8080)).unwrap();
socket.write(bytes!("GET / HTTP/1.0\n\n"));
let response = socket.read_to_end();
```
Expand All @@ -99,7 +99,7 @@ Some examples of obvious things you might want to do
use std::io::{TcpListener, TcpStream};
use std::io::{Acceptor, Listener};

let listener = TcpListener::bind("127.0.0.1", 80);
let listener = TcpListener::bind(("127.0.0.1", 80));

// bind the listener to the specified address
let mut acceptor = listener.listen();
Expand Down
Loading