rewrite outlives placeholder constraints to outlives static when handling opaque types #147566
+95
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
opaque_types_placeholder_outlives
branch
from
fd26c38 to
7ad74c0
Compare
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
opaque_types_placeholder_outlives
branch
from
7ad74c0 to
aea3cae
Compare
This comment has been minimized.
This comment has been minimized.
BoxyUwU
commented
Oct 10, 2025
Comment on lines
+307
to
+310
| debug!( | ||
| "compute_definition_site_hidden_types_from_defining_use: UnexpectedHiddenRegion for {:?}", | ||
| this_use, | ||
| ); |
There was a problem hiding this comment.
this seems to have caused the entire match to have gotten reflowed :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147529
r? lcnr
see test comment