Skip to content

Conversation

hkBst
Copy link
Member

@hkBst hkBst commented Oct 10, 2025

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2025

Some changes occurred in cfg and check-cfg configuration

cc @Urgau

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 10, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] object test:false 0.743
error[E0308]: mismatched types
   --> src/bootstrap/src/utils/helpers/tests.rs:50:43
    |
 50 |     assert_eq!(check_cfg_arg("bootstrap", None), "--check-cfg=cfg(bootstrap)");
    |                -------------              ^^^^ expected `&[&str]`, found `Option<_>`
    |                |
    |                arguments to this function are incorrect
    |
    = note: expected reference `&[&str]`
                    found enum `std::option::Option<_>`
note: function defined here
   --> src/bootstrap/src/utils/helpers.rs:494:8
    |
494 | pub fn check_cfg_arg(name: &str, values: &[&str]) -> String {
    |        ^^^^^^^^^^^^^             ---------------

error[E0308]: mismatched types
   --> src/bootstrap/src/utils/helpers/tests.rs:52:38
    |
 52 |         check_cfg_arg("target_arch", Some(&["s360"])),
    |         -------------                ^^^^^^^^^^^^^^^ expected `&[&str]`, found `Option<&[&str; 1]>`
    |         |
    |         arguments to this function are incorrect
    |
    = note: expected reference `&[&str]`
                    found enum `std::option::Option<&[&str; 1]>`
note: function defined here
   --> src/bootstrap/src/utils/helpers.rs:494:8
    |
494 | pub fn check_cfg_arg(name: &str, values: &[&str]) -> String {
    |        ^^^^^^^^^^^^^             ---------------

error[E0308]: mismatched types
   --> src/bootstrap/src/utils/helpers/tests.rs:56:36
    |
 56 |         check_cfg_arg("target_os", Some(&["nixos", "nix2"])),
    |         -------------              ^^^^^^^^^^^^^^^^^^^^^^^^ expected `&[&str]`, found `Option<&[&str; 2]>`
    |         |
    |         arguments to this function are incorrect
    |
    = note: expected reference `&[&str]`
                    found enum `std::option::Option<&[&str; 2]>`
note: function defined here
   --> src/bootstrap/src/utils/helpers.rs:494:8
    |
494 | pub fn check_cfg_arg(name: &str, values: &[&str]) -> String {
    |        ^^^^^^^^^^^^^             ---------------

For more information about this error, try `rustc --explain E0308`.
[RUSTC-TIMING] bootstrap test:true 3.608
error: could not compile `bootstrap` (lib test) due to 3 previous errors

@Urgau
Copy link
Member

Urgau commented Oct 10, 2025

r? Urgau

@rustbot rustbot assigned Urgau and unassigned Mark-Simulacrum Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants