-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[perf] Test mimalloc 3.1.5 #147583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[perf] Test mimalloc 3.1.5 #147583
Conversation
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
[perf] Test mimalloc 3.1.5
Do NOT merge this, I didn't even change the |
Yup, that's what I started :) |
This comment has been minimized.
This comment has been minimized.
Mhm! Just wanted to make it very clear. |
@Kobzol well... tidy most likely won't work; why? I think I forgot to add make and stuff... |
The features have to be fixed. |
@Kobzol Bright minds think alike, huh? ...maybe it's people who can read and comprehend english and basic programming (aka. me!) but who knows :P |
?r @Kobzol |
@Kobzol Could you run bors again? I think everything is correct now. |
I'll start it once the PR jobs are green or made enough progress. |
This comment has been minimized.
This comment has been minimized.
@bors try |
This comment has been minimized.
This comment has been minimized.
[perf] Test mimalloc 3.1.5
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
@Kobzol I fixed tidy. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💔 Test for 556be92 failed: CI. Failed jobs:
|
checksum = "667f4fec20f29dfc6bc7357c582d91796c169ad7e2fce709468aefeb2c099870" | ||
dependencies = [ | ||
"cc", | ||
"cty", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this dependency is used for c_char, c_int, c_long and c_ulonglong, which are all provided by core::ffi
nowadays.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjorn3 as this is a test, im js gonna allow the dep
@bors try |
@umbrageodotus: 🔑 Insufficient privileges: not in try users |
@bors try |
This comment has been minimized.
This comment has been minimized.
[perf] Test mimalloc 3.1.5
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test for c15b50c failed: CI. Failed jobs:
|
(test for #147583 - message copy pasted and adapted from
mimalloc
2.x test)Last times we tried
mimalloc
:jemalloc
mimalloc
had interesting performance characteristics but max-rss regressions, that were supposed to be fixed in 2.x (spoiler: weren't), which was apparently in beta at the time.We'd like to have more up-to-date numbers for comparison. (My expectations: some perf improvements, but only non-significant max-rss regressions, unlike last time)
r? @Noratrieb