Skip to content

Conversation

umbrageodotus
Copy link

@umbrageodotus umbrageodotus commented Oct 11, 2025

(test for #147583 - message copy pasted and adapted from mimalloc 2.x test)

Last times we tried mimalloc:

  • We were comparing to a different release of jemalloc
  • The 1.x version of mimalloc had interesting performance characteristics but max-rss regressions, that were supposed to be fixed in 2.x (spoiler: weren't), which was apparently in beta at the time.
    We'd like to have more up-to-date numbers for comparison. (My expectations: some perf improvements, but only non-significant max-rss regressions, unlike last time)

r? @Noratrieb

@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

Noratrieb is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 11, 2025
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 11, 2025
@umbrageodotus
Copy link
Author

Do NOT merge this, I didn't even change the feature names. Just a bench.

@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

Yup, that's what I started :)

@rust-log-analyzer

This comment has been minimized.

@umbrageodotus
Copy link
Author

Yup, that's what I started :)

Mhm! Just wanted to make it very clear.

@umbrageodotus
Copy link
Author

umbrageodotus commented Oct 11, 2025

@Kobzol well... tidy most likely won't work; why? I think I forgot to add make and stuff...

@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

feature jemalloc includes dep:tikv-jemalloc-sys, but tikv-jemalloc-sys is not listed as a dependency

The features have to be fixed.

@umbrageodotus
Copy link
Author

umbrageodotus commented Oct 11, 2025

@Kobzol Bright minds think alike, huh? ...maybe it's people who can read and comprehend english and basic programming (aka. me!) but who knows :P

@umbrageodotus
Copy link
Author

?r @Kobzol

@umbrageodotus
Copy link
Author

@Kobzol Could you run bors again? I think everything is correct now.

@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

I'll start it once the PR jobs are green or made enough progress.

@rust-bors
Copy link

rust-bors bot commented Oct 11, 2025

💔 Test for 1b28ff3 failed: CI

@rust-log-analyzer

This comment has been minimized.

@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 11, 2025

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 11, 2025
@umbrageodotus
Copy link
Author

@Kobzol I fixed tidy.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Oct 11, 2025

💔 Test for 556be92 failed: CI. Failed jobs:

checksum = "667f4fec20f29dfc6bc7357c582d91796c169ad7e2fce709468aefeb2c099870"
dependencies = [
"cc",
"cty",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this dependency is used for c_char, c_int, c_long and c_ulonglong, which are all provided by core::ffi nowadays.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjorn3 as this is a test, im js gonna allow the dep

@umbrageodotus
Copy link
Author

@bors try

@rust-bors
Copy link

rust-bors bot commented Oct 11, 2025

@umbrageodotus: 🔑 Insufficient privileges: not in try users

@umbrageodotus
Copy link
Author

@Kobzol Could you "@bors try"? It passed tidy, so...

@Kobzol
Copy link
Member

Kobzol commented Oct 11, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Oct 11, 2025
@rust-log-analyzer
Copy link
Collaborator

The job dist-x86_64-linux failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 31.08s
##[endgroup]
[2025-10-11T13:25:48.803Z INFO  opt_dist::timer] Section `Stage 1 (Rustc PGO)` starts
[2025-10-11T13:25:48.803Z INFO  opt_dist::timer] Section `Stage 1 (Rustc PGO) > Build PGO instrumented rustc and LLVM` starts
[2025-10-11T13:25:48.803Z INFO  opt_dist::exec] Executing `RUST_BACKTRACE=full python3 /checkout/x.py build --target x86_64-unknown-linux-gnu --host x86_64-unknown-linux-gnu --stage 2 library/std --set rust.llvm-bitcode-linker=false --set build.extended=false --set rust.codegen-backends=['llvm'] --set rust.deny-warnings=false --rust-profile-generate /tmp/tmp-multistage/opt-artifacts/rustc-pgo --set llvm.thin-lto=false --set llvm.link-shared=true [at /checkout/obj]`
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.06s
##[endgroup]
[TIMING:start] compile::Assemble { target_compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu, forced_compiler: false } }
[TIMING:start] builder::Libdir { compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu }
---
[2025-10-11T13:51:32.336Z INFO  opt_dist::utils::io] Deleting directory `/tmp/tmp-multistage/opt-artifacts/rustc-pgo`
[2025-10-11T13:51:35.678Z INFO  opt_dist::timer] Section `Stage 1 (Rustc PGO) > Gather profiles` ended: OK (598.42s)`
[2025-10-11T13:51:35.678Z INFO  opt_dist::utils] Free disk space: 1.24 TiB out of total 2.18 TiB (43.16% used)
[2025-10-11T13:51:35.678Z INFO  opt_dist::timer] Section `Stage 1 (Rustc PGO) > Build PGO optimized rustc` starts
[2025-10-11T13:51:35.678Z INFO  opt_dist::exec] Executing `RUST_BACKTRACE=full python3 /checkout/x.py build --target x86_64-unknown-linux-gnu --host x86_64-unknown-linux-gnu --stage 2 library/std --set rust.llvm-bitcode-linker=false --set build.extended=false --set rust.codegen-backends=['llvm'] --set rust.deny-warnings=false --rust-profile-use /tmp/tmp-multistage/opt-artifacts/rustc-pgo.profdata --enable-bolt-settings [at /checkout/obj]`
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.27s
##[endgroup]
[TIMING:start] compile::Assemble { target_compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu, forced_compiler: false } }
[TIMING:start] builder::Libdir { compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu }
---
[2025-10-11T13:57:12.507Z INFO  opt_dist::utils] Clearing LLVM build files
[2025-10-11T13:57:12.507Z INFO  opt_dist::utils::io] Deleting directory `/checkout/obj/build/x86_64-unknown-linux-gnu/llvm`
[2025-10-11T13:57:13.677Z INFO  opt_dist::utils::io] Deleting directory `/checkout/obj/build/x86_64-unknown-linux-gnu/lld`
[2025-10-11T13:57:13.713Z INFO  opt_dist::timer] Section `Stage 2 (LLVM PGO) > Build PGO instrumented LLVM` starts
[2025-10-11T13:57:13.713Z INFO  opt_dist::exec] Executing `LLVM_PROFILE_DIR=/tmp/tmp-multistage/opt-artifacts/llvm-pgo/prof-%p RUST_BACKTRACE=full python3 /checkout/x.py build --target x86_64-unknown-linux-gnu --host x86_64-unknown-linux-gnu --stage 2 library/std --set rust.llvm-bitcode-linker=false --set build.extended=false --set rust.codegen-backends=['llvm'] --set rust.deny-warnings=false --llvm-profile-generate --keep-stage 0 --keep-stage 1 [at /checkout/obj]`
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.07s
##[endgroup]
[TIMING:start] compile::Assemble { target_compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu, forced_compiler: false } }
[TIMING:start] builder::Libdir { compiler: Compiler { stage: 2, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu }
---
Running with 1 job(s)
collector error: Cannot find libdir for rustc

Caused by:
    rustc failed to provide sysroot, exit status: signal: 11 (SIGSEGV) (core dumped)
    stderr: 

Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
             at /cargo/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.86/src/backtrace.rs:27:14
---
   7: std::sys::backtrace::__rust_begin_short_backtrace
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/sys/backtrace.rs:158:18
   8: std::rt::lang_start::{{closure}}
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/rt.rs:206:18
   9: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/core/src/ops/function.rs:287:21
  10: std::panicking::catch_unwind::do_call
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/panicking.rs:590:40
  11: std::panicking::catch_unwind
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/panicking.rs:553:19
---
    0: Cannot gather LLVM PGO profiles
    1: Command RUSTC=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustc RUSTC_BOOTSTRAP=1 /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo run -p collector --bin collector -- profile_local eprintln /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc --id Test --cargo /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo --profiles Debug,Opt --scenarios Full --exact-match syn-2.0.101,cargo-0.87.1,serde-1.0.219,ripgrep-14.1.1,regex-automata-0.4.8,clap_derive-4.5.32,hyper-1.6.0 [at /tmp/tmp-multistage/opt-artifacts/rustc-perf] has failed with exit code Some(1)

Stack backtrace:
   0: <anyhow::Error>::msg::<alloc::string::String>
             at /rust/deps/anyhow-1.0.99/src/backtrace.rs:27:14
   1: <opt_dist::exec::CmdBuilder>::run
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/exec.rs:80:17
   2: opt_dist::training::gather_llvm_profiles::{closure#0}
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/training.rs:123:30
   3: opt_dist::utils::with_log_group::<opt_dist::training::gather_llvm_profiles::{closure#0}, core::result::Result<(), anyhow::Error>>
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/utils/mod.rs:68:22
   4: opt_dist::training::gather_llvm_profiles
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/training.rs:122:5
   5: opt_dist::execute_pipeline::{closure#2}::{closure#1}
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/main.rs:293:17
   6: <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#2}::{closure#1}, opt_dist::training::LlvmPGOProfile>
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/timer.rs:111:22
   7: opt_dist::execute_pipeline::{closure#2}
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/main.rs:292:33
   8: <opt_dist::timer::TimerSection>::section::<opt_dist::execute_pipeline::{closure#2}, core::option::Option<opt_dist::training::LlvmPGOProfile>>
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/timer.rs:111:22
   9: opt_dist::execute_pipeline
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/main.rs:279:15
  10: opt_dist::main
             at /rustc/c15b50cd29a9e31550dbbb2375b2fedf46fa00c2/src/tools/opt-dist/src/main.rs:467:18
  11: <fn() -> core::result::Result<(), anyhow::Error> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/core/src/ops/function.rs:250:5
  12: std::sys::backtrace::__rust_begin_short_backtrace::<fn() -> core::result::Result<(), anyhow::Error>, core::result::Result<(), anyhow::Error>>
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/sys/backtrace.rs:158:18
  13: std::rt::lang_start::<core::result::Result<(), anyhow::Error>>::{closure#0}
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/rt.rs:206:18
  14: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/core/src/ops/function.rs:287:21
  15: std::panicking::catch_unwind::do_call
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/panicking.rs:590:40
  16: std::panicking::catch_unwind
             at /rustc/bb624dcb4c8ab987e10c0808d92d76f3b84dd117/library/std/src/panicking.rs:553:19

@rust-bors
Copy link

rust-bors bot commented Oct 11, 2025

💔 Test for c15b50c failed: CI. Failed jobs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidy Area: The tidy tool S-waiting-on-perf Status: Waiting on a perf run to be completed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants