Skip to content

Conversation

chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 12, 2025

Fixes #141385

r? @estebank

I added a group BuiltinCombinedLateLintPass is because module_lints is run per-module:
https://github.com/chenyukang/rust/blob/e7391b2f97ecb889cf48a1e83732bef64db0a575/compiler/rustc_lint/src/late.rs#L468-L471
but this check needs a recursive way so it's in crate_lints.

I'd like to make sure everything is OK in rustc lint before we remove it from clippy.

One thing I'm worried is this may report warning for those project without clippy checking, since now it's a builtin check and default is warn.

It's better to keep the same behavior with clippy, so how do we handle allow_private_module_inception option in clippy..

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 12, 2025
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lint on mod foo {} inside of foo.rs

4 participants