Uplift module inspect from clippy #147599
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141385
r? @estebank
I added a group
BuiltinCombinedLateLintPass
is becausemodule_lints
is run per-module:https://github.com/chenyukang/rust/blob/e7391b2f97ecb889cf48a1e83732bef64db0a575/compiler/rustc_lint/src/late.rs#L468-L471
but this check needs a recursive way so it's in crate_lints.
I'd like to make sure everything is OK in rustc lint before we remove it from clippy.
One thing I'm worried is this may report warning for those project without clippy checking, since now it's a builtin check and default is
warn
.It's better to keep the same behavior with clippy, so how do we handle
allow_private_module_inception
option in clippy..