Skip to content

Fix export import conflicts for llvm #147600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix export import conflicts for llvm #147600

wants to merge 2 commits into from
+3 −1

Conversation

RobertBColton
Copy link

@RobertBColton RobertBColton commented Oct 12, 2025 •
edited by rustbot
Loading

Trying to fix #113050 for #110489 so I can make Windows easier to set up.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Zalathar
Copy link
Contributor

Zalathar commented Oct 12, 2025 •
edited
Loading

When you're satisfied that PR CI checks have succeeded, please squash any “fixup” commits into the main commit/commits, to make review easier and keep history simple.

@RobertBColton RobertBColton force-pushed the fix-export-import-conflicts branch from 239f780 to b678202 Compare October 12, 2025 08:48
@RobertBColton
Copy link
Author

Done

Zalathar
Zalathar reviewed Oct 12, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zalathar Zalathar Zalathar left review comments

Assignees

@nnethercote nnethercote

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#[link(kind="raw-dylib")] mis-compiles if cdylib export has the same name

5 participants

@RobertBColton @rustbot @rust-log-analyzer @Zalathar @nnethercote