Fix file descriptors leak in do_exec #147656
Open
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
chenyukang
commented
Oct 14, 2025
|
|
||
| // SAFETY: Dropping `stdio` (ChildPipes) is safe here since ChildPipes | ||
| // does not involve heap memory allocations | ||
| debug_assert!(size_of::<ChildPipes>() <= 24); |
There was a problem hiding this comment.
the intension is make sure ChildPipes does not involve heap allocations,
mem::needs_drop does not work here, since ChildPipes -> ChildStdio -> FileDesc,
and FileDesc impl Drop.
any better way to achieve the assertion?
|
See #147624 (comment) for why I don't think this is necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147624