Replace manual implementation with carrying_mul_add
#147666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
scottmcm
approved these changes
Oct 14, 2025
| (carry as $bigty); | ||
| ((v >> <$ty>::BITS) as $ty, v as $ty) | ||
| let (lo, hi) = self.carrying_mul_add(other, other2, carry); | ||
| (hi, lo) |
There was a problem hiding this comment.
Oh, interesting that this method had picked the opposite order. I guess we were all taught math in big-endian, even if it's kinda worse 🙃
There was a problem hiding this comment.
Yeah, it was not obvious at first, so it took some time to understand why tests are not passing
Oh, I can't do it 😅 so I'm worry you will need to r+ it yourself or delegate rights for this one |
|
@bors r=scottmcm |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #146277 (comment)
r? scottmcm