rust-analyzer subtree update
#147671
Closed
rust-analyzer subtree update
#147671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example
---
```rust
fn main() {
let bar = Some(true);
if true && bar.$0
}
```
**Before this PR**:
Cannot complete `.let`
**After this PR**:
```rust
fn main() {
let bar = Some(true);
if true && let Some($0) = bar
}
```
Add support for else-block of never-type for `convert_to_guarded_return`
Example
---
```rust
fn main() {
if$0 let Ok(x) = Err(92) {
foo(x);
} else {
return
}
}
```
**Before this PR**:
Assist not applicable
**After this PR**:
```rust
fn main() {
let Ok(x) = Err(92) else {
return
};
foo(x);
}
```
By setting RUSTUP_AUTO_INSTALL=0.
Example
---
```rust
fn foo() {
let x;
if true {
match true {
true => $0x = 2,
false => x = 3,
}
}
}
```
**Before this PR**:
Assist not applicable
**After this PR**:
```rust
fn foo() {
let x;
if true {
x = match true {
true => 2,
false => 3,
};
}
}
```
internal: Build x86_64-apple-darwin binaries on macos-14
internal: Migrate inference to next solver
…nresolved fix: Ignore impl trait safety errors when the trait is unresolved
This updates the rust-version file to 3369e82.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 3369e82 Filtered ref: abf6c425d3a4688fd64d51be9adef24ec58e128b Upstream diff: rust-lang/rust@f957826...3369e82 This merge was created using https://github.com/rust-lang/josh-sync.
Fix small things clippy was complaining about
minor: Rustc pull update
…o-install fix: Prevent rustup from automatically installing toolchains
Example
---
```rust
fn foo() {
bar(|| $0);
}
fn bar(f: impl FnOnce() -> u32) {}
```
**Before this PR**:
```
ty: impl FnOnce() -> u32, name: ?
```
**After this PR**:
```
ty: u32, name: ?
```
Fix empty closure completion analysis
…-let Fix not applicable on param in let-stmt for add_explicit_type
Fix closure coerced return type for add_return_type
minor: Small fixes for import insertion
…hain Fix .let completion not work for let-chain
Example
---
Assist: `make_raw_string`
```rust
fn f() {
let s = $0b"random\nstring";
}
```
->
```rust
fn f() {
let s = br#"random
string"#;
}
```
---
Assist: `make_raw_string`
```rust
fn f() {
let s = $0c"random\nstring";
}
```
->
```rust
fn f() {
let s = cr#"random
string"#;
}
```
---
Assist: `add_hash`
```rust
fn f() {
let s = $0cr"random string";
}
```
->
```rust
fn f() {
let s = cr#"random string"#;
}
```
---
Assist: `remove_hash`
```rust
fn f() {
let s = $0cr#"random string"#;
}
```
->
```rust
fn f() {
let s = cr"random string";
}
```
---
Assist: `make_usual_string`
```rust
fn f() {
let s = $0cr#"random string"#;
}
```
->
```rust
fn f() {
let s = c"random string";
}
```
Fix not applicable c-str and byte-str for raw_string
internal: Migrate MIR to next solver
Migrate `hir` types to next solver
Example
---
```rust
fn foo() -> bool {
let$0 Some(x) = Some(2) else { return false };
}
```
**Before this PR**:
```rust
fn foo() -> bool {
let Some(Some(x)) = Some(2) else { return };
}
```
**After this PR**:
Assist not applicable
…ist-else Fix applicable on let-else for convert_to_guarded_return
Add else-block support for convert_to_guarded_return
…gn-up Fix not applicable match inside if for pull_assignment_up
```rust
fn foo() -> i32 {
loop {
$0
}
}
```
**Before this PR**:
```rust
fn foo() -> i32 {
loop {
break;
}
}
```
**After this PR**:
```rust
fn foo() -> i32 {
loop {
break $0;
}
}
```
Add break value completion support
This updates the rust-version file to fb24b04.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: fb24b04 Filtered ref: 8d328b994c70dfeed12717a13a915703ec939cfc Upstream diff: rust-lang/rust@3369e82...fb24b04 This merge was created using https://github.com/rust-lang/josh-sync.
minor: sync from downstream
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
rustbot
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtree update of
rust-analyzerto rust-lang/rust-analyzer@c4fbb96.Created using https://github.com/rust-lang/josh-sync.
r? @ghost