update isolate_highest_one for NonZero<T> #147686
Open
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Let
x = self
andm = (((1 as $Int) << (<$Int>::BITS - 1)).wrapping_shr(self.leading_zeros()))
Then the previous code computed
NonZero::new_unchecked(x & m)
.Since
m
has exactly one bit set (the most significant 1-bit ofx
),(x & m) == m
.Therefore, the masking step was redundant.
The shift is safe and does not need wrapping because:
self.leading_zeros() < $Int::BITS
becauseself
is non-zero.unchecked_shr
is non-zero, satisfying theNonZero
invariant. if wrapping happens we would be violatingNonZero
invariants.why this micro optimization?
the old code was suboptimal it duplicated
$Int
’s isolate_highest_one logic instead of delegating to it. Since the type already wraps$Int
, either delegation should be used for clarity or, if keeping a custom implementation, it should be optimized as above.