Fix #15453 #15454
Closed
Fix #15453 #15454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if every commit or PR had at least a summary line of the issue it fixes. |
|
@blake2-ppc Oh sorry. Definitely. Will keep in mind. |
bors
added a commit
that referenced
this pull request
Jul 6, 2014
I forget we now have byte string literals.
ghost
deleted the
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 22, 2025
) Per the root readme, `clippy::style` is a category with > code that should be written in a more idiomatic way description. The code this lint guards from may be much worse than badly styled: ```rs use std::sync::LazyLock; // `const` instead of `static` causes `dbg!` to be printed 10 times // instead of one. const LICENSE_FILE_NAME_REGEX: LazyLock<String> = LazyLock::new(|| { dbg!("I am a large regex initialized in a lazy lock!"); format!("Hello {}", "World".to_string()) }); fn main() { for _ in 0..10 { let _ = LICENSE_FILE_NAME_REGEX.split(" "); } } ``` In large projects, it's unfortunate but sometimes possible to see style lints suppressed with ```toml [workspace.lints.clippy] style = { level = "allow", priority = -1 } ``` effectively turning off crucial checks for the code like above. To keep them, promote this lint to `clippy::suspicious`: > code that is most likely wrong or useless category that has the same, `warn` default level, thus not failing on false-positives which lead to rust-lang/rust-clippy#5863 --- changelog: [`declare_interior_mutable_const`]: promote lint's category to `clippy::suspicious`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forget we now have byte string literals.