typeck::check::_match: Better error handling #15538
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| Some(_) => {}, | ||
| None => { | ||
| tcx.sess.span_err(path.span, "This shouldn't happen: failed to lookup structure") |
There was a problem hiding this comment.
Could you print out the item_did too? And this should use .span_bug, not .span_err.
|
Updated the patch. |
|
Needs a rebase |
Previously this was an Option::unwrap() which failed for me. Unfortunately I've since inadvertently worked around the bug and have been unable to reproduce it. With this patch hopefully the next person to encounter this will be in a slightly better position to debug it.
|
Done. |
|
Closing due to inactivity, but feel free to reopen with a rebase! |
|
@alexcrichton actually it accidentally snuck into #15585. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
add option to show full function signatures in completion docs implements rust-lang#15538 with `"rust-analyzer.completion.fullFunctionSignatures.enable": false`:  with `"rust-analyzer.completion.fullFunctionSignatures.enable": true`: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was an Option::unwrap() which failed for me.
Unfortunately I've since inadvertently worked around the bug and have
been unable to reproduce it. With this patch hopefully the next person
to encounter this will be in a slightly better position to debug it.