Skip to content

Conversation

treeman
Copy link
Contributor

@treeman treeman commented Jul 16, 2014

Also use /// for documentation instead of /**. End comments with ..

//! ```rust
//! # use num::bigint::BigUint;
//! # use std::num::{Zero, One};
//! # use std::mem::replace;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This imports seem genuinely useful for the program below, so they shouldn't be hidden.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same with the ones below)

@treeman
Copy link
Contributor Author

treeman commented Jul 16, 2014

That's a good point.

@alexcrichton
Copy link
Member

Looks good to me! Could you squash these commits together as well?

Also use `///` for documentation instead of `/**`. End comments with
`.`.

Show imports for bigint example.

They might be useful.
@treeman
Copy link
Contributor Author

treeman commented Jul 16, 2014

Done, I hope!

bors added a commit that referenced this pull request Jul 17, 2014
Also use `///` for documentation instead of `/**`. End comments with `.`.
@bors bors closed this Jul 17, 2014
@treeman treeman deleted the bigint-doc branch July 20, 2014 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants