Remove outdated unreachable check from `call_visit_glue` #15784

Merged
merged 2 commits into from Jul 20, 2014

Projects

None yet

3 participants

@dotdash
Collaborator
dotdash commented Jul 18, 2014

call_visit_glue is only ever called from trans_intrinsic, and the
block won't be unreachable there. Also, the comment doesn't make sense
anymore. When the code was introduced in 38fee95 the function was
also responsible for the cleanup glue, which is no longer the case.

While we're at it, also fixed the debug message to output the right
function name.

@dotdash dotdash Remove outdated unreachable check from `call_visit_glue`
`call_visit_glue` is only ever called from trans_intrinsic, and the
block won't be unreachable there. Also, the comment doesn't make sense
anymore. When the code was introduced in 38fee95 the function was
also responsible for the cleanup glue, which is no longer the case.

While we're at it, also fixed the debug message to output the right
function name.
33a4dd8
@luqmana
Member
luqmana commented Jul 18, 2014

We might as well just remove that last argument since it's only ever called with None.

@dotdash dotdash Remove the unneeded final parameter from call_visit_glue
call_visit_glue() is only ever called with None as its last argument, so
we can remove it as well.
d368ffd
@luqmana
Member

r+

Collaborator
bors replied Jul 20, 2014

saw approval from luqmana
at dotdash@d368ffd

Collaborator
bors replied Jul 20, 2014

merging dotdash/rust/unreach = d368ffd into auto

Collaborator
bors replied Jul 20, 2014

dotdash/rust/unreach = d368ffd merged ok, testing candidate = 50481f5

Collaborator
bors replied Jul 20, 2014

fast-forwarding master to auto = 50481f5

@bors bors added a commit that referenced this pull request Jul 20, 2014
@bors bors auto merge of #15784 : dotdash/rust/unreach, r=luqmana
`call_visit_glue` is only ever called from trans_intrinsic, and the
block won't be unreachable there. Also, the comment doesn't make sense
anymore. When the code was introduced in 38fee95 the function was
also responsible for the cleanup glue, which is no longer the case.

While we're at it, also fixed the debug message to output the right
function name.
50481f5
@bors bors closed this Jul 20, 2014
@bors bors merged commit d368ffd into rust-lang:master Jul 20, 2014

2 checks passed

Details continuous-integration/travis-ci The Travis CI build passed
default all tests passed
@dotdash dotdash deleted the dotdash:unreach branch Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment