native, rustuv: Fix spawning with empty args #16284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -479,7 +479,7 @@ fn make_command_line(prog: &CString, args: &[CString]) -> String { | |||
| return cmd; | |||
|
|
|||
| fn append_arg(cmd: &mut String, arg: &str) { | |||
| let quote = arg.chars().any(|c| c == ' ' || c == '\t'); | |||
| let quote = arg.chars().any(|c| c == ' ' || c == '\t') || arg.len() == 0; | |||
There was a problem hiding this comment.
Worth a comment, because it seems somewhat surprising? ("empty arguments on windows need to be explicitly quoted")
|
Travis failed in a way that looks like it may be relevant. |
There was a bug in both libnative and libuv which prevented child processes from being spawned correctly on windows when one of the arguments was an empty string. The libuv bug has since been fixed upstream, and the libnative bug was fixed as part of this commit. When updating libuv, this also includes a fix for rust-lang#15149. Closes rust-lang#15149 Closes rust-lang#16272
|
I think it should be better now, the test suite all passed locally at least. |
bors
added a commit
that referenced
this pull request
Aug 12, 2014
There was a bug in both libnative and libuv which prevented child processes from being spawned correctly on windows when one of the arguments was an empty string. The libuv bug has since been fixed upstream, and the libnative bug was fixed as part of this commit. When updating libuv, this also includes a fix for #15149. Closes #15149 Closes #16272
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
fix: Fix panic on unaligned packed attribute Closes rust-lang#16284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in both libnative and libuv which prevented child processes from
being spawned correctly on windows when one of the arguments was an empty
string. The libuv bug has since been fixed upstream, and the libnative bug was
fixed as part of this commit.
When updating libuv, this also includes a fix for #15149.
Closes #15149
Closes #16272