Document that CStrings live in the libc heap #17355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Insists on the fact that the memory is managed by malloc and not jemalloc Closes rust-lang#17067
| @@ -36,6 +36,11 @@ not tied to the lifetime of the original string/data buffer). If C strings are | |||
| heavily used in applications, then caching may be advisable to prevent | |||
| unnecessary amounts of allocations. | |||
|
|
|||
| Be carefull to remember that the memory is managed by libc's malloc and not | |||
There was a problem hiding this comment.
The default memory allocator is not always jemalloc - it's an implementation detail. It shouldn't be mentioned in any of the documentation like this. The libc symbols may also be resolving to symbols provided by jemalloc, so it's not accurate to explain it this way. The only thing the documentation should say is that it's not well defined to mix the C allocator API with the Rust allocator API. The underlying allocator beneath either API is not defined.
There was a problem hiding this comment.
So replacing l
-"libc's malloc" by "C allocator API"
-"jemalloc" by "Rust allocator"
Does the trick ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insists on the fact that the memory is managed by malloc
and not jemalloc
Closes #17067