Defailbloat fail!(&'static str) #17602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand how this bootstraps, since rust/src/libsyntax/diagnostic.rs Line 86 in 9a68da7 |
|
In std failure is handled differently than in core, for some reason |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 29, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 28, 2024
fix: handle synonymous imports with different renaming in 'merge imports' fix rust-lang#17602
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Aug 1, 2024
fix: handle synonymous imports with different renaming in 'merge imports' fix rust-lang#17602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc.rlib before: 77429264
rustc.rlib after: 76977406
This bloats Option::expects a bit, but it doesn't seem to be a problem.
This makes fail!(msg) assume that msg is a &'static str, change instances where this is not the case to fail!("{}", msg)
Closes #15792
[breaking-change]