Improve code in the intro. #18253
Merged
Improve code in the intro. #18253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -471,7 +471,7 @@ fn main() { | |||
| spawn(proc() { | |||
| let mut array = number.lock(); | |||
|
|
|||
| (*(*array).get_mut(i)) += 1; | |||
| *(array.get_mut(i)) += 1; | |||
There was a problem hiding this comment.
Firstly, the parens aren't actually needed here, secondly (yay!) mutable indexing now works (works as well as immutable indexing, anyway, so the [] syntax can be used: (*array)[i] += 1.
There was a problem hiding this comment.
oh sweet! I didn't try hard enough i guess :)
|
r=me with more square brackets. 😄 |
All these stars aren't needed anymore.
steveklabnik
force-pushed
the
small_doc_fixes
branch
from
0b8b150 to
4a74af6
Compare
steveklabnik
added a commit
to steveklabnik/hello_rust
that referenced
this pull request
Oct 23, 2014
bors
added a commit
that referenced
this pull request
Oct 23, 2014
All these stars aren't needed anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All these stars aren't needed anymore.