syntax: improve message for misused inner attributes #18766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
| @@ -75,6 +75,8 @@ impl<'a> ParserAttr for Parser<'a> { | |||
| self.span_err(span, | |||
| "an inner attribute is not permitted in \ | |||
| this context"); | |||
| self.span_note(span, | |||
| "put inner attribute in top of file or block"); | |||
There was a problem hiding this comment.
Could you change this message to "place inner attribute at the top of the module or block"?
There was a problem hiding this comment.
I think this should also be a span_help instead of a span_note.
liigo
force-pushed
the
improve-inner-attr-msg
branch
from
450588a to
0a52cc3
Compare
|
@huonw I have changed the message to what you suggested, and changed to |
bors
added a commit
that referenced
this pull request
Nov 11, 2014
for the code:
```
use std::io;
#![crate_type="rlib"] // ERROR: an inner attribute is not permitted in this context
fn say_hello() {
println!("hello");
}
```
this PR provides another note to help programmer fixing this error more easily:
```
hello.rs:6:3: 6:4 error: an inner attribute is not permitted in this context
hello.rs:6 #![crate_type="rlib"]
^
hello.rs:6:3: 6:4 note: put inner attribute in top of file or block
hello.rs:6 #![crate_type="rlib"]
^
```
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the code:
this PR provides another note to help programmer fixing this error more easily: