Don't inherit stability to items in a function body. #19029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vberger Thanks for the PR! It seems to me that we just shouldn't apply any stability level to these internal items, since stability is wholly about public APIs. Seems like it should be as easy as halting the recursive walk altogether (which would treat the stability as unmarked). What do you think? |
|
@aturon I was not really sure about this, that's why I only prevented inheritance. But yeah, given stability is only relevant for public APIs, there is no real point in marking these items at all, so halting the recursion is probably a better choice. I'll change it. |
Items defined in the body of a function has no visibility outside it, and thus have no reason to be marked with stability attributes. Closes #17488
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 27, 2025
internal: Skip redundant path search in `resolve_completion_edits`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items defined in the body of a function has no visibility outside it, and thus have no reason to inherit its stability.
Closes #17488