Rename FPCategory, FP* to FpCategory, Fp* to adhere to the naming convention
#19758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess |
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 12, 2014
This is a [breaking-change].
brson
added a commit
to brson/rust
that referenced
this pull request
Dec 13, 2014
This is a [breaking-change].
|
@brson Rebased. |
bors
added a commit
that referenced
this pull request
Dec 19, 2014
Rename `FPCategory`, `FP*` to `FpCategory`, `Fp*` to adhere to the naming convention Reviewed-by: Gankro
bors
referenced
this pull request
Dec 19, 2014
| @@ -18,7 +18,7 @@ pub use self::SignFormat::*; | |||
|
|
|||
| use char::{mod, Char}; | |||
| use kinds::Copy; | |||
| use num::{mod, Int, Float, FPNaN, FPInfinite, ToPrimitive}; | |||
| use num::{mod, Int, Float, FpNaN, FpInfinite, ToPrimitive}; | |||
There was a problem hiding this comment.
This got a problem! You should rename it to FpNa**n**.
|
Needs a rebase |
| /// "Not a Number", often obtained by dividing by zero | ||
| FPNaN, | ||
| FpNan, |
There was a problem hiding this comment.
Seems to me like the Fp part of these should be dropped entirely.
There was a problem hiding this comment.
@sfackler So it should be FpCategory::Infinite? That sounds too long IMO.
There was a problem hiding this comment.
If using it frequently, you can use FpCategory as Fp, or just use FpCategory::*.
|
@alexcrichton Rebased. |
|
Ah yes I agree with @sfackler, could the |
|
@alexcrichton Here you go! |
Rename `FPCategory` to `FpCategory` and `Fp* to `*` in order to adhere to the
naming convention
This is a [breaking-change].
Existing code like this:
```
use std::num::{FPCategory, FPNaN};
```
should be adjusted to this:
```
use std::num::FpCategory as Fp
```
In the following code you can use the constants `Fp::Nan`, `Fp::Normal`, etc.
|
@alexcrichton Rebased after merge failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a [breaking-change].