Implement Clone for iterator adaptors using functions #19837
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impl Clone wherever the underlying iterator and the predicate / mapping function implement Clone. For example bare functions impl Clone + FnMut, so such functions used with .map() will produce a clonable iterator. With this change, str's .bytes() iterator becomes clonable. Add a single test that execises .clone() on a Map.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
|
I believe this is already accomplished by #19827 |
|
Thank you for the pointer, I think this PR accomplishes it better. |
|
Superseded by the other PR. |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jun 16, 2025
Provide better incrementality when items are changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
impl Clone wherever the underlying iterator and the predicate / mapping
function implement Clone. For example bare functions impl Clone + FnMut,
so such functions used with .map() will produce a clonable iterator.
With this change, str's .bytes() iterator becomes clonable.
Add a single test that execises .clone() on a Map.