Skip to content

Conversation

TisButMe
Copy link

I bumped into this yesterday while writing some hashmap code.

This is minor, feel free to ignore if you end up removing the method anyway.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@TisButMe TisButMe closed this Dec 24, 2014
@TisButMe
Copy link
Author

The code seems to actually use cloned(), I'll look into into a bit more before reopening.

@sfackler
Copy link
Member

cloned() turns an Option<&T> and returns an Option<T> by cloning the T inside. clone() just takes an Option<&T> and returns a new Option<&T>.

@TisButMe
Copy link
Author

Thanks for the info :) I wondered where was cloned coming from.

lnicola pushed a commit to lnicola/rust that referenced this pull request Jul 18, 2025
…xrvpywtvoys

Revert "Re-enable fixpoint iteration for variance computation"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants