Skip to content

Conversation

suhr
Copy link

@suhr suhr commented Jan 2, 2015

Subj.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@alexcrichton
Copy link
Member

Unfortunately this will need to wait until we get a new snapshot that understand derive, or otherwise stage0 won't build :(

@japaric
Copy link
Contributor

japaric commented Jan 4, 2015

A snapshot just landed, I think this is unblocked now.

@Gankra
Copy link
Contributor

Gankra commented Jan 4, 2015

Needs a rebase :(

@suhr
Copy link
Author

suhr commented Jan 4, 2015

Looks like everything is fixed by 351409a.

@suhr suhr closed this Jan 4, 2015
lnicola pushed a commit to lnicola/rust that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants