std: Tweak String implementations #20722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @aturon cc @seanmonstar |
alexcrichton
force-pushed
the
audit-show
branch
from
ce12834 to
7d79d56
Compare
| @@ -806,6 +808,7 @@ impl Default for String { | |||
| } | |||
|
|
|||
| #[experimental = "waiting on fmt stabilization"] | |||
This commit performs a pass over the implementations of the new `String` trait
in the formatting module. Some implementations were removed as a conservative
move pending an upcoming convention about `String` implementations, and some
were added in order to retain consistency across the libraries. Specifically:
* All "smart pointers" implement `String` now, adding missing implementations
for `Arc` and `Rc`.
* The `Vec<T>` and `[T]` types no longer implement `String`.
* The `*const T` and `*mut T` type no longer implement `String`.
* The `()` type no longer implements `String`.
* The `Path` type's `Show` implementation does not surround itself with `Path
{}` (a minor tweak).
All implementations of `String` in this PR were also marked `#[stable]` to
indicate that the types will continue to implement the `String` trait regardless
of what it looks like.
alexcrichton
force-pushed
the
audit-show
branch
from
7d79d56 to
9851b4f
Compare
|
|
||
| #[cfg(not(stage0))] | ||
| #[experimental = "waiting on Show stability"] | ||
| impl<T: fmt::String> fmt::String for Vec<T> { |
There was a problem hiding this comment.
I believe this was used by rustdoc, to print arguments and generics and the like.
There was a problem hiding this comment.
Or well, the slice version of this.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 8, 2015
Conflicts: src/libcollections/vec.rs src/libcore/fmt/mod.rs src/librustdoc/html/format.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit performs a pass over the implementations of the new
Stringtraitin the formatting module. Some implementations were removed as a conservative
move pending an upcoming convention about
Stringimplementations, and somewere added in order to retain consistency across the libraries. Specifically:
Stringnow, adding missing implementationsfor
ArcandRc.Vec<T>and[T]types no longer implementString.*const Tand*mut Ttype no longer implementString.()type no longer implementsString.Pathtype'sShowimplementation does not surround itself withPath {}(a minor tweak).