Remove special casing for old obsolete syntax #21088
Conversation
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -33,7 +33,6 @@ pub mod attr; | |||
|
|
|||
| pub mod common; | |||
| pub mod classify; | |||
| pub mod obsolete; | |||
There was a problem hiding this comment.
We may not want to remove this module entirely, it's a useful pattern which we can continue to move obsolete parsing to over time. The contents of the module can certainly be trimmed down, however.
There was a problem hiding this comment.
I was thinking about it... Do you think this module will be useful after reaching post 1.0, when no backwards-incompatible changes are allowed?
There was a problem hiding this comment.
I don't think it'd be useful at all after 1.0, but we may make some more syntax tweaks in the period before 1.0 where this would still be useful.
There was a problem hiding this comment.
Then I guess we would also want to keep the latest special cases (enum variants: ClosureType, ForSized, Sized, ProcType, ProcExpr). I will update the PR with this changes.
Thanks for the feedback!
aochagavia
changed the title
|
@alexcrichton @sfackler I have updated the PR! |
| @@ -4454,13 +4395,6 @@ impl<'a> Parser<'a> { | |||
| eself | |||
| } | |||
| token::Tilde => { | |||
There was a problem hiding this comment.
I think this whole arm can be deleted actually
|
Thanks! Just one small nit and otherwise r=me |
|
@alexcrichton Done! |
Only the most recent changes (since November 2014) get a special error. Fixes rust-lang#20599
Only the most recent changes (since November 2014) get a special error.
Fixes #20599