Documenting libcore/char.rs #21567
Merged
Documenting libcore/char.rs #21567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| /// ``` | ||
| /// use std::char; | ||
| /// | ||
| /// let c = char::from_digit(4, 10); |
There was a problem hiding this comment.
Perhaps add assert_eq!(c, '4')?
|
r=me with nits, nice! |
| /// assert_eq!(heart, "\\u{2764}"); | ||
| /// ``` | ||
| /// | ||
| /// Note the extra `\` on the right hand side, so that we don't end up interpolating the |
There was a problem hiding this comment.
s/right hand/right-hand/
steveklabnik
force-pushed
the
doc_char
branch
from
1d4ec84 to
46f609a
Compare
|
@alexcrichton @apasel422 rebased and re-incorporated. alex said r=me but I'd still like someone to double check other than me 😄 |
| /// " | ||
| /// ``` | ||
| /// | ||
| /// Collecting to a `String`: |
There was a problem hiding this comment.
On line 220 you have "Collecting into a String."
steveklabnik
force-pushed
the
doc_char
branch
from
46f609a to
fcf1a57
Compare
|
@bors: rollup |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.