Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _VALUE from the float extremes constants. #22254

Merged
merged 1 commit into from Feb 16, 2015

Conversation

huonw
Copy link
Member

@huonw huonw commented Feb 13, 2015

In std::f32 and std::f64:

  • MIN_VALUEMIN
  • MAX_VALUEMAX
  • MIN_POS_VALUEMIN_POSITIVE

This matches the corresponding integer constants.

[breaking-change]

In `std::f32` and `std::f64`:

- `MIN_VALUE` → `MIN`
- `MAX_VALUE` → `MAX`
- `MIN_POS_VALUE` → `MIN_POSITIVE`

This matches the corresponding integer constants.

[breaking-change]
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Feb 13, 2015

@bors: r+ e4a9eb9

@aturon
Copy link
Member

aturon commented Feb 13, 2015

@bors: rollup

@nikomatsakis nikomatsakis assigned aturon and unassigned nikomatsakis Feb 13, 2015
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 13, 2015
In `std::f32` and `std::f64`:

- `MIN_VALUE` → `MIN`
- `MAX_VALUE` → `MAX`
- `MIN_POS_VALUE` → `MIN_POSITIVE`

This matches the corresponding integer constants.

[breaking-change]
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 14, 2015
In `std::f32` and `std::f64`:

- `MIN_VALUE` → `MIN`
- `MAX_VALUE` → `MAX`
- `MIN_POS_VALUE` → `MIN_POSITIVE`

This matches the corresponding integer constants.

[breaking-change]
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 15, 2015
In `std::f32` and `std::f64`:

- `MIN_VALUE` → `MIN`
- `MAX_VALUE` → `MAX`
- `MIN_POS_VALUE` → `MIN_POSITIVE`

This matches the corresponding integer constants.

[breaking-change]
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 15, 2015
 In `std::f32` and `std::f64`:

- `MIN_VALUE` → `MIN`
- `MAX_VALUE` → `MAX`
- `MIN_POS_VALUE` → `MIN_POSITIVE`

This matches the corresponding integer constants.

[breaking-change]
@bors bors merged commit e4a9eb9 into rust-lang:master Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants