Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer updates #22256

Merged
merged 4 commits into from Feb 16, 2015

Conversation

@brson
Copy link
Contributor

brson commented Feb 13, 2015

Highlights:

  • Adds an 'uninstall.sh' script to /usr/local/lib/rustlib/uninstall.sh, the path to which is printed during installation.
  • Components can be deselected during install, like install.sh --without=rust-docs.
  • Components can be listed with install.sh --list-components.
  • Vastly reduces spew during install (but supporting a --verbose option).

Typicall install run looks like:

brian@brianX1:~/dev/multirust⟫ sudo ./install.sh 
[sudo] password for brian:
install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'cargo'
install: installing component 'rust-docs'

    Rust is ready to roll.

Needs to be merged right before corresponding PRs to cargo and rust-packaging.

Fixes #21117
Fixes #20283

brson added 4 commits Feb 11, 2015
The quick start already links to the book. I think its not necessary
to do in the build instructions.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Feb 13, 2015

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Feb 13, 2015

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Feb 13, 2015

cc @steveklabnik This tweaks the very first section of the README and The Book's uninstall instructions.

@brson

This comment has been minimized.

Copy link
Contributor Author

brson commented Feb 13, 2015

Oh, if not everything lands together in time for a nightly I expect it shouldn't result in major problems like last time. Now that the installers are versioned they should not clobber each other, but the combined build will probably fail.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Feb 14, 2015

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 15, 2015
 Highlights:

* Adds an 'uninstall.sh' script to `/usr/local/lib/rustlib/uninstall.sh`, the path to which is printed during installation.
* Components can be deselected during install, like `install.sh --without=rust-docs`.
* Components can be listed with `install.sh --list-components`.
* Vastly reduces spew during install (but supporting a `--verbose` option).

Typicall install run looks like:

```
brian@brianX1:~/dev/multirust⟫ sudo ./install.sh
[sudo] password for brian:
install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'cargo'
install: installing component 'rust-docs'

    Rust is ready to roll.
```

Needs to be merged right before corresponding PRs to cargo and rust-packaging.

Fixes rust-lang#21117
Fixes rust-lang#20283
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 15, 2015
 Highlights:

* Adds an 'uninstall.sh' script to `/usr/local/lib/rustlib/uninstall.sh`, the path to which is printed during installation.
* Components can be deselected during install, like `install.sh --without=rust-docs`.
* Components can be listed with `install.sh --list-components`.
* Vastly reduces spew during install (but supporting a `--verbose` option).

Typicall install run looks like:

```
brian@brianX1:~/dev/multirust⟫ sudo ./install.sh
[sudo] password for brian:
install: creating uninstall script at /usr/local/lib/rustlib/uninstall.sh
install: installing component 'rustc'
install: installing component 'cargo'
install: installing component 'rust-docs'

    Rust is ready to roll.
```

Needs to be merged right before corresponding PRs to cargo and rust-packaging.

Fixes rust-lang#21117
Fixes rust-lang#20283
@bors bors merged commit 9df38bf into rust-lang:master Feb 16, 2015
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
bors added a commit to rust-lang/cargo that referenced this pull request Feb 16, 2015
Needs to land immediately after rust-lang/rust#22256.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.