Reintroduce box syntax where needed #22267
Merged
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
It seems strange to recommend a feature-gated pattern. We should perhaps at least clarify that this is feature-gated? |
|
Well it wasn't gated originally and it's one of the primary reasons to remove the gate. Is it worth adding that sentence when the gate is gonna end up coming off soon anyway? |
|
@steveklabnik It is not clear when the gate will come off. (For more details, see some notes here: https://github.com/rust-lang/meeting-minutes/blob/master/weekly-meetings/2015-02-10.md#fallout-of-box-rfc ) |
|
Gotcha. I'll add a note about the gate, I guess, then. |
|
Updated. |
steveklabnik
force-pushed
the
fix_lie
branch
from
46a7d11 to
5ce1b33
Compare
Otherwise, this line is a lie.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 21, 2015
Otherwise, this line is a lie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, this line is a lie.