Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

we forgot to make Path implement Hash #22351

Merged
merged 1 commit into from
Feb 16, 2015
Merged

Conversation

blaenk
Copy link
Contributor

@blaenk blaenk commented Feb 15, 2015

PathBuf does implement Hash, but Path doesn't. This makes it
annoying if you have a HashMap with PathBufs as keys, because
it means you have to convert a Path into a PathBuf and get a
reference to it simply to perform operations on the HashMap!

`PathBuf` does implement `Hash`, but `Path` doesn't. This makes it
annoying if you have a `HashMap` with `PathBuf`s as keys, because
it means you have to convert a `Path` into a `PathBuf` and get a
reference to it simply to perform operations on the `HashMap`!
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@blaenk
Copy link
Contributor Author

blaenk commented Feb 15, 2015

This is my first, glorious contribution. I hope I didn't screw it up D:

@huonw
Copy link
Member

huonw commented Feb 15, 2015

@bors r+ 10dd rollup

@huonw
Copy link
Member

huonw commented Feb 15, 2015

Thanks, seems fine to me!

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 15, 2015
 `PathBuf` does implement `Hash`, but `Path` doesn't. This makes it
annoying if you have a `HashMap` with `PathBuf`s as keys, because
it means you have to convert a `Path` into a `PathBuf` and get a
reference to it simply to perform operations on the `HashMap`!
@bors bors merged commit 10dd8e7 into rust-lang:master Feb 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants