Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix normalization involving bound regions #22785

Merged

Conversation

nikomatsakis
Copy link
Contributor

Two changes:

  1. Make traits with assoc types invariant w/r/t their inputs.
  2. Fully normalize parameter environments, including any region variables (which were being overlooked).

The former supports the latter, but also just seems like a reasonably good idea.

Fixes #21750

cc @edwardw
r? @pnkfelix

//!
//! <T as Trait> <: <U as Trait>
//!
//! means that if I know that `T as Trait`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, what the heck happened to your emacs fill-paragraph settings here...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I originally wrote that in a different location. I tried to refill all the paragraphs but I guess I missed one :)

@pnkfelix
Copy link
Member

@bors r+ 206c254 rollup

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 25, 2015
…ion-with-regions, r=pnkfelix

 Two changes:

1. Make traits with assoc types invariant w/r/t their inputs.
2. Fully normalize parameter environments, including any region variables (which were being overlooked).

The former supports the latter, but also just seems like a reasonably good idea.

Fixes rust-lang#21750

cc @edwardw
r? @pnkfelix
@bors bors merged commit 206c254 into rust-lang:master Feb 25, 2015
@nikomatsakis nikomatsakis deleted the issue-21750-normalization-with-regions branch March 30, 2016 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE in region_inference/mod.rs
3 participants