Skip to content

Conversation

Manishearth
Copy link
Member

edwardw and others added 7 commits February 28, 2015 22:39
These implementations were temporary workaround. Now rust-lang#22828 has been
fixed, they can be removed.
some commits in OpenBSD base have corrected a problem of stack position.
Now, we can adjust more accurately the page guard in rust.
static_assert is documented as working on static with type `bool`, but
we currently accept it on any const static and crash when the const has
an non-integral type.

This is a breaking-change for anyone who used static_assert on types
likes i32, which happened to work but seems like an unintended
consequence of the missing error checking.

[breaking-change]

Fixes rust-lang#22056
@Manishearth
Copy link
Member Author

@bors: p=20 r+

1 similar comment
@Manishearth
Copy link
Member Author

@bors: p=20 r+

@bors
Copy link
Collaborator

bors commented Feb 28, 2015

@bors r=Manishearth 679e9b2

@bors
Copy link
Collaborator

bors commented Feb 28, 2015

⌛ Testing commit 679e9b2 with merge 5e0f38a...

The timing code break when using multiple codegen units, but that
shouldn't stop us from using it with a single codegen unit.
@bors
Copy link
Collaborator

bors commented Feb 28, 2015

💔 Test failed - auto-win-64-opt

 These implementations were temporary workaround. Now rust-lang#22828 has been
fixed, they can be removed.
 A misplaced uint->u32 instead of usize in fmt::Pointer. Added a basic test.
 some commits in OpenBSD OS have corrected a problem of stack position.
Now, we can adjust more accurately the page guard in rust.

@dhuseby I am not sure that bitrig have already integrated these changes (the `$OpenBSD$` header in sys/kern/kern_exec.c is too old). But when they do, you may want this patch too.
 static_assert is documented as working on static with type `bool`, but
we currently accept it on any const static and crash when the const has
an non-integral type.

This is a breaking-change for anyone who used static_assert on types
likes i32, which happened to work but seems like an unintended
consequence of the missing error checking.

[breaking-change]

Fixes rust-lang#22056
@Manishearth
Copy link
Member Author

@bors: r+

@bors
Copy link
Collaborator

bors commented Mar 1, 2015

@bors r=Manishearth 60f7732

 The markdown listing the link in [StrExt::width](http://doc.rust-lang.org/std/str/trait.StrExt.html#tymethod.width) isn't being parsed properly. I'm expecting it's because the `[ ]` is across 2 lines so this changes that. This is untested though.
 The timing code break when using multiple codegen units, but that
shouldn't stop us from using it with a single codegen unit.
@bors
Copy link
Collaborator

bors commented Mar 1, 2015

⌛ Testing commit 60f7732 with merge 0905c8a...

bors added a commit that referenced this pull request Mar 1, 2015
@bors
Copy link
Collaborator

bors commented Mar 1, 2015

@bors bors merged commit 60f7732 into rust-lang:master Mar 1, 2015
@Manishearth Manishearth deleted the rollup branch March 1, 2015 09:00
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants