std: Fix peeling ports from addresses #23097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rsplitn` call was called with 2 instead of 1 so the iterator would yield 3 items in some cases, not the 2 that it should have. Closes rust-lang#23076
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ 65b4eda |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 6, 2015
The `rsplitn` call was called with 2 instead of 1 so the iterator would yield 3 items in some cases, not the 2 that it should have. Closes rust-lang#23076
|
This seems to be causing panics within panics on Windows (only) @retep998 got a sortof-backtrace |
|
Note that error was from building the rollup PR which happened to include this PR. I am still working on building just this PR. Unfortunately LLVM really likes to rebuild all the time. |
|
This is the error I get when running |
|
Yeah, same test, just that the doublepanic doesn't happen |
|
This is not the cause of the double panic. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 6, 2015
The `rsplitn` call was called with 2 instead of 1 so the iterator would yield 3 items in some cases, not the 2 that it should have. Closes rust-lang#23076
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rsplitncall was called with 2 instead of 1 so the iterator would yield 3items in some cases, not the 2 that it should have.
Closes #23076