Fix documentation for StrExt::trim_matches #23455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @gankro (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -923,11 +923,12 @@ pub trait StrExt: Index<RangeFull, Output = str> { | |||
|
|
|||
| /// Returns a string with all pre- and suffixes that match a pattern repeatedly removed. | |||
| /// | |||
| /// The pattern can be a simple `&str`, or a closure that determines the split. | |||
| /// The pattern is required to be a `DoubleEndedSearcher`, therefore `&str` patterns cannot | |||
| /// be used. | |||
There was a problem hiding this comment.
This lost the 'closure' aspect. I would change this to read:
The pattern can be any
DoubleEndedSearcher, including a closure that determines the split.
This keeps it overall more consistent with the rest of the other examples.
|
r=me after the little nit |
|
@steveklabnik updated. |
|
Thanks so much! |
|
@bors: r+ rollup |
|
📌 Commit 34c48db has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Mar 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.