Skip to content

Conversation

ranma42
Copy link
Contributor

@ranma42 ranma42 commented Apr 3, 2015

MacOS X does not ship with Java installed by default. Instead it
includes binary stubs that upon execution pop up a message suggesting
the installation of the JDK.

Since javac is only used when antlr4 is available, it is possible
to work around the popup by only probing for javac if antlr4 has
been successfully detected (in which case the JDK is probably already
installed on the system).

Fixes #23138.

MacOS X does not ship with Java installed by default. Instead it
includes binary stubs that upon execution pop up a message suggesting
the installation of the JDK.

Since `javac` is only used when `antlr4` is available, it is possible
to work around the popup by only probing for `javac` if `antlr4` has
been successfully detected (in which case the JDK is probably already
installed on the system).

Fixes rust-lang#23138.
@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+ 0621a83

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 3, 2015
…excrichton

MacOS X does not ship with Java installed by default. Instead it
includes binary stubs that upon execution pop up a message suggesting
the installation of the JDK.

Since `javac` is only used when `antlr4` is available, it is possible
to work around the popup by only probing for `javac` if `antlr4` has
been successfully detected (in which case the JDK is probably already
installed on the system).

Fixes rust-lang#23138.
bors added a commit that referenced this pull request Apr 3, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 4, 2015
…excrichton

 MacOS X does not ship with Java installed by default. Instead it
includes binary stubs that upon execution pop up a message suggesting
the installation of the JDK.

Since `javac` is only used when `antlr4` is available, it is possible
to work around the popup by only probing for `javac` if `antlr4` has
been successfully detected (in which case the JDK is probably already
installed on the system).

Fixes rust-lang#23138.
@bors bors merged commit 0621a83 into rust-lang:master Apr 4, 2015
@ranma42 ranma42 deleted the macosx-no-javac-popup branch April 4, 2015 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustc configure pops up dialog about javac on OS X
5 participants