New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive: Give access to field attributes in ext::deriving #25027

Merged
merged 3 commits into from May 2, 2015

Conversation

Projects
None yet
3 participants
@Manishearth
Member

Manishearth commented May 1, 2015

Adds an attrs field to FieldInfo which lets one check the attributes on
a field whilst expanding.

This lets deriving plugins be more robust, for example providing the ability to
"ignore" a field for the purpose of deriving, or perhaps handle the field a
different way.

r? @huonw

@huonw

This comment has been minimized.

Show comment
Hide comment
@huonw

huonw May 2, 2015

Member

r=me with the whitespace fix. Also, tidy failed on travis.

Member

huonw commented May 2, 2015

r=me with the whitespace fix. Also, tidy failed on travis.

@Manishearth

This comment has been minimized.

Show comment
Hide comment
@Manishearth

Manishearth May 2, 2015

Member

@bors: r=huonw

Member

Manishearth commented May 2, 2015

@bors: r=huonw

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 2, 2015

Contributor

📌 Commit 5892b40 has been approved by huonw

Contributor

bors commented May 2, 2015

📌 Commit 5892b40 has been approved by huonw

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors May 2, 2015

Contributor

⌛️ Testing commit 5892b40 with merge 354d16b...

Contributor

bors commented May 2, 2015

⌛️ Testing commit 5892b40 with merge 354d16b...

bors added a commit that referenced this pull request May 2, 2015

Auto merge of #25027 - Manishearth:deriving_attr, r=huonw
Adds an `attrs` field to `FieldInfo` which lets one check the attributes on
a field whilst expanding.

This lets deriving plugins be more robust, for example providing the ability to
"ignore" a field for the purpose of deriving, or perhaps handle the field a
different way.


r? @huonw

@bors bors merged commit 5892b40 into rust-lang:master May 2, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Manishearth Manishearth deleted the Manishearth:deriving_attr branch May 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment